PR to add some commands and fix one minor issues#6
Open
kwccoin wants to merge 10 commits intojborza:masterfrom
Open
PR to add some commands and fix one minor issues#6kwccoin wants to merge 10 commits intojborza:masterfrom
kwccoin wants to merge 10 commits intojborza:masterfrom
Conversation
I wonder whether 2 better imprvoment
- use asd fg hjkl;'
1234 56 7shcd
- this is keyboard based (ncureses is as well)
- and fixed foundation to spade-heart-clubs-diamond
- I also wornder one add a command call auto for end game i.e. random check any one card and if can move to foundation move it and continues move it until it cannot (i.e. save the end game time)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug fix need +1 to fix the error about range of destination and source.
The issue is that some commands also check the source/destination index e.g. 798-813 (my adjusted source). They should be the last as u has no src/dest, w has no src, c may use f etc. Hence a change would avoid valgrind alert use of uninitiated variables. Minor as it does no cause bug as it is alway wrong.
I add some commands
r for refresh as some debugging in valgrind of print out better to have refresh command
q with high score
h for help message (and a hint at least h)
Further action:
Doc
Input
Source
a) command mode see 2,
b) object mode not sure and
c) function mode passing state
Mostly c as that is the Real Game I want to try
GUI
BTW, never pay solitaire but this one is quit addictive, partially because one page C with a fast text game without using mouse. Great work as said. Hope I am not too annoying.